server_environment: running_env default to `test` (fix #44) #45

simahawk · 2020-04-01T10:20:26Z

No description provided.

This is not needed anymore since OCA#45

simahawk · 2020-04-01T11:51:03Z

tests to be fixed. No time now, I'll get back ASAP.

This is not needed anymore since OCA#45

dreispt · 2020-04-02T13:31:02Z

.travis.yml

@@ -41,8 +41,6 @@ install:
    ${HOME}/maintainer-quality-tools
  - export PATH=${HOME}/maintainer-quality-tools/travis:${PATH}
  - travis_install_nightly
-  # Requirements to test server_environment modules
-  - printf '[options]\n\nrunning_env = dev\n' > ${HOME}/.openerp_serverrc


dreispt · 2020-04-02T13:33:45Z

Tests need some love.

server_environment/server_env.py

bodedra

LGTM 👍

pedrobaeza

I still don't understand why this is "activated" by default without installing the module, but if working, OK for me.

I wish also that you use Doodba for deploying avoiding all these modules, but that's too much, hehe.

simahawk · 2020-04-10T09:38:22Z

I squash and merge as it gets green again. Runbot is 🟠 only indeed.

simahawk · 2020-04-10T09:43:49Z

I wish also that you use Doodba for deploying avoiding all these modules, but that's too much, hehe.

why would it help?

pedrobaeza · 2020-04-10T09:45:43Z

You won't need these modules with that deployment method.

Note that Doodba serves for production, staging and devel environments.

simahawk · 2020-04-10T09:48:36Z

eh same here w/ our docker image. The point is: how do you deal w/ model / modules / params / whatever specific configurable variables?
This is not about odoo config only.

pedrobaeza · 2020-04-10T09:52:08Z

We have our scaffolding for that, that now has been powered-up with copier templating system. AFAIK, you have modules for:

mail configuration. We put it on the scaffolding.
different Odoo configurations. The same.
ir_config_parameter. We inject this through Ansible, as we consider this more a DevOps, but scaffolding can be expanded for that if you switch and consider it interesting 😉

Note that secrets are not hardcoded in the scaffolding.

simahawk · 2020-04-10T09:59:12Z

we do the same, we have templates for them.
The point is, if you want to customize via env the behavior of a model you cannot do it w/ templating.
For instance, the mail server: https://github.com/OCA/server-env/blob/13.0/mail_environment/models/ir_mail_server.py#L12
And for secrets: this is already handled as well. You can have public vars and secret vars.

pedrobaeza · 2020-04-10T10:05:05Z

Uhm, having Mailhog without configuring anything in our Doodba staging seems enough for us sincerely.

dreispt · 2020-04-10T11:10:12Z

Thank you!
Can this be backported to 12.0 please?

This is not needed anymore since OCA#45

simahawk · 2020-04-16T12:23:56Z

v11 #46

This is not needed anymore since OCA#45

alexey-pelykh · 2020-04-16T12:53:39Z

v12 #47

The PR #45 has been merged manually and a new version was not bumped.

The PR OCA#45 has been merged manually and a new version was not bumped.

The PR #45 has been merged manually and a new version was not bumped.

The PR OCA#45 has been merged manually and a new version was not bumped.

The PR #45 has been merged manually and a new version was not bumped.

simahawk force-pushed the 13-default-running-env branch from d1d6259 to 168d7ca Compare April 1, 2020 10:23

simahawk changed the title ~~server_environemnt: running_env default to dev (fix #44)~~ server_environemnt: running_env default to test (fix #44) Apr 1, 2020

simahawk mentioned this pull request Apr 1, 2020

Odoo Critical error "failed to initialize database" once server_environemnt is installed #44

Closed

simahawk added this to the 13.0 milestone Apr 1, 2020

simahawk added the needs review label Apr 1, 2020

simahawk changed the title ~~server_environemnt: running_env default to test (fix #44)~~ server_environment: running_env default to test (fix #44) Apr 1, 2020

simahawk force-pushed the 13-default-running-env branch from 168d7ca to 3ef4aea Compare April 1, 2020 10:25

bealdav approved these changes Apr 1, 2020

View reviewed changes

simahawk added a commit to simahawk/server-env that referenced this pull request Apr 1, 2020

Travis: remove running_env config

fe16a51

This is not needed anymore since OCA#45

simahawk added a commit to simahawk/server-env that referenced this pull request Apr 2, 2020

Travis: remove running_env config

5ba996a

This is not needed anymore since OCA#45

simahawk force-pushed the 13-default-running-env branch from e6e3196 to 5ba996a Compare April 2, 2020 07:37

simahawk added a commit to simahawk/server-env that referenced this pull request Apr 2, 2020

Travis: remove running_env config

e48f752

This is not needed anymore since OCA#45

simahawk force-pushed the 13-default-running-env branch from 5ba996a to e48f752 Compare April 2, 2020 07:49

simahawk added 2 commits April 2, 2020 09:50

server_environment: running_env default to test (fix OCA#44)

121a432

Travis: remove running_env config

46337ae

This is not needed anymore since OCA#45

simahawk force-pushed the 13-default-running-env branch from e48f752 to 46337ae Compare April 2, 2020 07:50

dreispt reviewed Apr 2, 2020

View reviewed changes

dreispt approved these changes Apr 2, 2020

View reviewed changes

OCA-git-bot added the approved label Apr 2, 2020

dreispt added the needs fixing label Apr 2, 2020

fixup! server_environment: running_env default to test (fix OCA#44)

3024745

simahawk force-pushed the 13-default-running-env branch from 5df8a5a to 3024745 Compare April 10, 2020 09:26

simahawk commented Apr 10, 2020

View reviewed changes

server_environment/server_env.py Show resolved Hide resolved

simahawk mentioned this pull request Apr 10, 2020

[FIX] prevent ocabot merges OCA/reporting-engine#384

Closed

bodedra approved these changes Apr 10, 2020

View reviewed changes

pedrobaeza approved these changes Apr 10, 2020

View reviewed changes

pedrobaeza merged commit 44d7573 into OCA:13.0 Apr 10, 2020

alexey-pelykh pushed a commit to brainbeanapps/server-env that referenced this pull request Apr 15, 2020

Travis: remove running_env config

6e9a407

This is not needed anymore since OCA#45

alexey-pelykh mentioned this pull request Apr 15, 2020

[11.0][FIX] server_environment: running_env default to test #46

Merged

alexey-pelykh pushed a commit to brainbeanapps/server-env that referenced this pull request Apr 15, 2020

Travis: remove running_env config

547ebae

This is not needed anymore since OCA#45

alexey-pelykh pushed a commit to brainbeanapps/server-env that referenced this pull request Apr 16, 2020

Travis: remove running_env config

31a51c6

This is not needed anymore since OCA#45

simahawk added a commit that referenced this pull request Jul 3, 2020

Fix server_environment version

17d2605

The PR #45 has been merged manually and a new version was not bumped.

simahawk mentioned this pull request Jul 3, 2020

Fix server_environment version #51

Merged

mourad-ehm pushed a commit to akretion/server-env that referenced this pull request Oct 12, 2020

Fix server_environment version

b79b441

The PR OCA#45 has been merged manually and a new version was not bumped.

sbejaoui pushed a commit to acsone/server-env that referenced this pull request Oct 14, 2020

Fix server_environment version

688e55b

The PR OCA#45 has been merged manually and a new version was not bumped.

JuMiSanAr pushed a commit to camptocamp/server-env that referenced this pull request Oct 18, 2021

Fix server_environment version

e460f44

The PR OCA#45 has been merged manually and a new version was not bumped.

JuMiSanAr pushed a commit to camptocamp/server-env that referenced this pull request Oct 22, 2021

Fix server_environment version

d0e55bd

The PR OCA#45 has been merged manually and a new version was not bumped.

simahawk added a commit to camptocamp/server-env that referenced this pull request Oct 22, 2021

Fix server_environment version

cac0126

The PR OCA#45 has been merged manually and a new version was not bumped.

FrancoMaxime pushed a commit to acsone/server-env that referenced this pull request Sep 1, 2022

Fix server_environment version

93eeed5

The PR OCA#45 has been merged manually and a new version was not bumped.

FrancoMaxime pushed a commit to acsone/server-env that referenced this pull request Oct 4, 2022

Fix server_environment version

42770eb

The PR OCA#45 has been merged manually and a new version was not bumped.

moitabenfdz pushed a commit to DynAppsNV/server-env that referenced this pull request Nov 13, 2023

Fix server_environment version

f4b9cee

The PR OCA#45 has been merged manually and a new version was not bumped.

thienvh332 pushed a commit to thienvh332/server-env that referenced this pull request Sep 20, 2024

Fix server_environment version

03658f1

The PR OCA#45 has been merged manually and a new version was not bumped.

thienvh332 pushed a commit to thienvh332/server-env that referenced this pull request Sep 24, 2024

Fix server_environment version

e19859c

The PR OCA#45 has been merged manually and a new version was not bumped.

sbidoul pushed a commit that referenced this pull request Sep 30, 2024

Fix server_environment version

8ef5147

The PR #45 has been merged manually and a new version was not bumped.

chaule97 pushed a commit to chaule97/server-env that referenced this pull request Oct 1, 2024

Fix server_environment version

4c97cad

The PR OCA#45 has been merged manually and a new version was not bumped.

chaule97 pushed a commit to chaule97/server-env that referenced this pull request Oct 1, 2024

Fix server_environment version

c8b35bc

The PR OCA#45 has been merged manually and a new version was not bumped.

chaule97 pushed a commit to chaule97/server-env that referenced this pull request Oct 1, 2024

Fix server_environment version

2de38eb

The PR OCA#45 has been merged manually and a new version was not bumped.

sbidoul pushed a commit that referenced this pull request Oct 2, 2024

Fix server_environment version

cf7c50f

The PR #45 has been merged manually and a new version was not bumped.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

server_environment: running_env default to `test` (fix #44) #45

server_environment: running_env default to `test` (fix #44) #45

simahawk commented Apr 1, 2020

simahawk commented Apr 1, 2020

dreispt Apr 2, 2020

dreispt commented Apr 2, 2020

bodedra left a comment

pedrobaeza left a comment

simahawk commented Apr 10, 2020

simahawk commented Apr 10, 2020

pedrobaeza commented Apr 10, 2020 •

edited

Loading

simahawk commented Apr 10, 2020 •

edited

Loading

pedrobaeza commented Apr 10, 2020 •

edited

Loading

simahawk commented Apr 10, 2020

pedrobaeza commented Apr 10, 2020

dreispt commented Apr 10, 2020

simahawk commented Apr 16, 2020

alexey-pelykh commented Apr 16, 2020

server_environment: running_env default to test (fix #44) #45

server_environment: running_env default to test (fix #44) #45

Conversation

simahawk commented Apr 1, 2020

simahawk commented Apr 1, 2020

dreispt Apr 2, 2020

Choose a reason for hiding this comment

dreispt commented Apr 2, 2020

bodedra left a comment

Choose a reason for hiding this comment

pedrobaeza left a comment

Choose a reason for hiding this comment

simahawk commented Apr 10, 2020

simahawk commented Apr 10, 2020

pedrobaeza commented Apr 10, 2020 • edited Loading

simahawk commented Apr 10, 2020 • edited Loading

pedrobaeza commented Apr 10, 2020 • edited Loading

simahawk commented Apr 10, 2020

pedrobaeza commented Apr 10, 2020

dreispt commented Apr 10, 2020

simahawk commented Apr 16, 2020

alexey-pelykh commented Apr 16, 2020

server_environment: running_env default to `test` (fix #44) #45

server_environment: running_env default to `test` (fix #44) #45

pedrobaeza commented Apr 10, 2020 •

edited

Loading

simahawk commented Apr 10, 2020 •

edited

Loading

pedrobaeza commented Apr 10, 2020 •

edited

Loading